Bottom margin of plot is to small

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Bottom margin of plot is to small

Michael Entrup
Hi,

when I run the following macro, the label of the x-axis is cut off:

        x = Array.getSequence(5);
        Plot.create("Example Plot", "q, y, g, j", "q, y, g, j", x, x);

Increasing BOTTOM_MARGIN (ij.gui.Plot.java line 110) from 37 to 42 fixes
the problem. I tested this value with different combinations of font
size and plot size.

Is there a way to fix such problems by myself and make a pull request?
The ImageJA repository [1] does not allow me to make pull requests.

Best regards
Michael


[1] https://github.com/imagej/ImageJA

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Bottom margin of plot is to small

Michael Entrup
Hi Wayne,

here are some screen shots, showing the problem with Fiji and pure IJ
(ImageJA in eclipse). I'm using Windows 7 Enterprise 64bit. I did "Edit
 > Options > Reset..." before running the small macro.
Today I tried the macro on Ubuntu 15.04 64bit, too. The characters are
touching the border. Maybe 1 pixel is cut off.
Seems the solution is not that easy, as I supposed. Three different OS
and three different looking plots...

Best regards
Michael


Am 19.08.2015 um 19:41 schrieb Rasband, Wayne (NIH/NIMH) [E]:

>> On Aug 19, 2015, at 4:39 AM, Michael Entrup
>> <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>> Hi,
>>
>> when I run the following macro, the label of the x-axis is cut off:
>>
>> x = Array.getSequence(5);
>> Plot.create("Example Plot", "q, y, g, j", "q, y, g, j", x, x);
>>
>> Increasing BOTTOM_MARGIN (ij.gui.Plot.java line 110) from 37 to 42
>> fixes the problem. I tested this value with different combinations of
>> font size and plot size.
>>
>> Is there a way to fix such problems by myself and make a pull
>> request? The ImageJA repository [1] does not allow me to make pull
>> requests.
>
> Hi Michael,
>
> I am unable to reproduce this problem on my Mac using Java 6 (see
> attached screenshot). What versions of ImageJ, OS and Java are you using?
>
> Best regards,
>
> -wayne
>

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Fiji-plot.png (32K) Download Attachment
Fiji-version.png (31K) Download Attachment
IJ-plot.png (33K) Download Attachment
IJ-version.png (31K) Download Attachment
Fiji(Ubuntu)-plot.png (16K) Download Attachment
Fiji(Ubuntu)-version.png (21K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bottom margin of plot is to small

ctrueden
Hi Michael,

You can contribute a patch for ImageJ1 as follows:

  http://imagej.net/Contributing#ImageJ1

The reason ImageJA is read-only is because it is automatically generated
from the imagej1 repo.

Regards,
Curtis
On Aug 20, 2015 7:18 AM, "Michael Entrup" <[hidden email]>
wrote:

> Hi Wayne,
>
> here are some screen shots, showing the problem with Fiji and pure IJ
> (ImageJA in eclipse). I'm using Windows 7 Enterprise 64bit. I did "Edit >
> Options > Reset..." before running the small macro.
> Today I tried the macro on Ubuntu 15.04 64bit, too. The characters are
> touching the border. Maybe 1 pixel is cut off.
> Seems the solution is not that easy, as I supposed. Three different OS and
> three different looking plots...
>
> Best regards
> Michael
>
>
> Am 19.08.2015 um 19:41 schrieb Rasband, Wayne (NIH/NIMH) [E]:
>
>> On Aug 19, 2015, at 4:39 AM, Michael Entrup <
>>> [hidden email] <mailto:[hidden email]>>
>>> wrote:
>>>
>>> Hi,
>>>
>>> when I run the following macro, the label of the x-axis is cut off:
>>>
>>> x = Array.getSequence(5);
>>> Plot.create("Example Plot", "q, y, g, j", "q, y, g, j", x, x);
>>>
>>> Increasing BOTTOM_MARGIN (ij.gui.Plot.java line 110) from 37 to 42 fixes
>>> the problem. I tested this value with different combinations of font size
>>> and plot size.
>>>
>>> Is there a way to fix such problems by myself and make a pull request?
>>> The ImageJA repository [1] does not allow me to make pull requests.
>>>
>>
>> Hi Michael,
>>
>> I am unable to reproduce this problem on my Mac using Java 6 (see
>> attached screenshot). What versions of ImageJ, OS and Java are you using?
>>
>> Best regards,
>>
>> -wayne
>>
>>
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html
>

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Bottom margin of plot is to small

Rasband, Wayne (NIH/NIMH) [E]
In reply to this post by Michael Entrup

> On Aug 19, 2015, at 4:39 AM, Michael Entrup <[hidden email]> wrote:
>
> Hi,
>
> when I run the following macro, the label of the x-axis is cut off:
>
> x = Array.getSequence(5);
> Plot.create("Example Plot", "q, y, g, j", "q, y, g, j", x, x);
>
> Increasing BOTTOM_MARGIN (ij.gui.Plot.java line 110) from 37 to 42 fixes the problem. I tested this value with different combinations of font size and plot size.
>
> Is there a way to fix such problems by myself and make a pull request? The ImageJA repository [1] does not allow me to make pull requests.

Hi Michael,

Your proposed fix for this problem is in the latest ImageJ daily build (1.50b12). You cannot fix problems like this yourself but you can send bug reports and bug fixes to me ([hidden email]) or use Fiji’s Help>Report a Bug command.

-wayne


--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html