Login  Register

Re: Removing NonBlockingGenericDialogs from the Window menu

Posted by Rasband, Wayne (NIH/NIMH) [E] on Mar 12, 2014; 10:07pm
URL: http://imagej.273.s1.nabble.com/Re-Removing-NonBlockingGenericDialogs-from-the-Window-menu-tp5006887p5006891.html

On Mar 12, 2014, at 3:39 PM, Ryota Homma wrote:

> Dear Wayne, Johannes, and all list members,
>
>> Date:    Mon, 3 Mar 2014 23:11:24 +0100
>> From:    Johannes Schindelin <[hidden email]>
>> Subject: Removing NonBlockingGenericDialogs from the Window menu
>>
>> Dear Wayne,
>>
>> I just noticed your fix:
>>
>> https://github.com/imagej/ImageJA/commit/fb84ee03bedc20c141716acd34ee6ad8c8e32c6d#diff-f393bd19cc4b42d8d8549c384ce229e3L21
>>
>> However, removing the window only when a button was clicked or a key was
>> pressed is very likely to miss the case where the dialog was closed
>> programmatically (e.g. when the dialog was only valid through the life
>> time of a long-running process, and closed when that process was done).
>
> I found the above indeed occurred with the latest daily build I tried (v1.48t2).
>
> When a plugin that would open a non-blocking generic dialog is called from
> a macro (in which the dialog is automatically OKed), the title of dialog is not
> removed from the Window menu.

This bug is fixed in the v1.48t3 daily build.

-wayne
--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html