Re: File selection in GenericDialog

Posted by ctrueden on Aug 18, 2017; 7:58pm
URL: http://imagej.273.s1.nabble.com/File-selection-in-GenericDialog-tp5019222p5019240.html

Hi Nico,

> I guess that I could simply include my own copy of the
> fiji.util.gui.GenericDialogPlus to make the plugin compatible with
> ImageJ1?

If you want to distribute your plugin to others, please do not fork classes
like that. Or if you do, at least rename it first. Otherwise, your plugin
and the Fiji distribution itself will have clashing code in
fiji.util.gui.GenericDialogPlus, and then anyone trying to use your plugin
in Fiji will have problems.

It is better to build on the existing libraries, and contribute any needed
changes upstream, rather than mutate them.

Regards,
Curtis

--
Curtis Rueden
LOCI software architect - https://loci.wisc.edu/software
ImageJ2 lead, Fiji maintainer - https://imagej.net/User:Rueden
Did you know ImageJ has a forum? http://forum.imagej.net/


On Fri, Aug 18, 2017 at 2:06 PM, Nico Stuurman <[hidden email]>
wrote:

> Hi Jan and others,
>
>
> Thanks!
>
> this feature was added in Fiji's GenericDialogPlus, see the addFileField()
>> and addDirectoryField() methods:
>>
>> http://javadoc.imagej.net/Fiji/fiji/util/gui/GenericDialogPlus.html
>>
>>
>> However, you shouldn't need to use GenericDialog or its derivatives at
>> all any more if you switch to using SciJava parameters:
>>
>
> Is it correct that none of these two solutions will work with the plain
> ImageJ1 distribution?
>
> I guess that I could simply include my own copy of the
> fiji.util.gui.GenericDialogPlus to make the plugin compatible with
> ImageJ1?
>
>
> Thanks!
>
>
>
> Nico
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html
>

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html