ImageJ

bug with Brightness & Contrast?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Cammer, Michael-3

bug with Brightness & Contrast?

I have been having problems with B&C for some time and would appreciate help.

When I adjust the contrast and hit apply, usually the contrast is not applied.

However, if I adjust the contrast and then duplicate the image, the resulting image does have the contrast applied.

I have posted examples.

Illustration of problem:
http://microscopynotes.com/temp/00_bandc_notapplied.png

Example image that does not work:
http://microscopynotes.com/temp/00_bandc_data.jpg

This has been a problem for at least two months and I checked it tonight with ImageJ 1.53g56 Java 1.8.0_172 Windows 10.

Any help appreciated.

Best regards-

Michael Cammer, Sr Research Scientist, DART Microscopy Laboratory

NYU Langone Health, 540 First Avenue, SK2 Microscopy Suite, New York, NY 10016

[hidden email]<mailto:[hidden email]> http://nyulmc.org/micros http://microscopynotes.com/

Voice direct only, no text or messages: 1-914-309-3270 and 1-646-501-0567

------------------------------------------------------------
This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain information that is proprietary, confidential, and exempt from disclosure under applicable law. Any unauthorized review, use, disclosure, or distribution is prohibited. If you have received this email in error please notify the sender by return email and delete the original message. Please note, the recipient should check this email and any attachments for the presence of viruses. The organization accepts no liability for any damage caused by any virus transmitted by this email.
=================================

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Wayne Rasband-2

Re: bug with Brightness & Contrast?

> On Nov 29, 2020, at 11:29 PM, Cammer, Michael <[hidden email]> wrote:
>
> I have been having problems with B&C for some time and would appreciate help.
>
>
> When I adjust the contrast and hit apply, usually the contrast is not applied.

I am not able to reproduce this problem using ImageJ 1.53g and Java 1.8.0_172 on MacOS and Windows.

-wayne

> However, if I adjust the contrast and then duplicate the image, the resulting image does have the contrast applied.
>
>
> I have posted examples.
>
> Illustration of problem:
> http://microscopynotes.com/temp/00_bandc_notapplied.png
>
>
> Example image that does not work:
> http://microscopynotes.com/temp/00_bandc_data.jpg
>
> This has been a problem for at least two months and I checked it tonight with ImageJ 1.53g56 Java 1.8.0_172 Windows 10.
>
> Any help appreciated.
>
> Best regards-
>
>
>
> Michael Cammer, Sr Research Scientist, DART Microscopy Laboratory
>
> NYU Langone Health, 540 First Avenue, SK2 Microscopy Suite, New York, NY 10016
>
> [hidden email]<mailto:[hidden email]> http://nyulmc.org/micros http://microscopynotes.com/
>
> Voice direct only, no text or messages: 1-914-309-3270 and 1-646-501-0567
>
>
> ------------------------------------------------------------
> This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain information that is proprietary, confidential, and exempt from disclosure under applicable law. Any unauthorized review, use, disclosure, or distribution is prohibited. If you have received this email in error please notify the sender by return email and delete the original message. Please note, the recipient should check this email and any attachments for the presence of viruses. The organization accepts no liability for any damage caused by any virus transmitted by this email.
> =================================
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Michael Schmid

Re: bug with Brightness & Contrast?

Hi Wayne, Michael,

this is nothing that I have seen with B&C (neither on small nor on large
images), but I do see a related problem with Image>Adjust>Color Balance
(It is there since a few months, I don't remember when I've noticed it
first). Maybe the two issues have the same root.

Color Balance problem:

Open Clown Sample
Adjust color balance of red channel
Click "Apply"
Message: "Warning, pixel values will change if you click ok"
Click ok
Switch to green channel on Color Balance
and the image has reverted.

ImageJ 1.53g57; Java 1.8.0_112 [64-bit]; Linux 4.4.0-194-generic

With B&C, as long as no other image is selected, the "Auto", "Set" and
"Reset" buttons also revert to the original settings after "Apply", and
also moving the sliders does not care about the previous 'Apply'; to me
this is not a bug but rather nice behavior. It may be an issue if one
wants to limit the values like this, hovever:
If I set the range to 0-127 to limit the max to 127, "apply", and then
change to 0-512, then we are back to the original image.
But this operation would be better done by Process>Math>Max anyhow.

Best,

Michael (one of the many :-)
________________________________________________________________
On 30.11.20 19:27, Wayne Rasband wrote:

>> On Nov 29, 2020, at 11:29 PM, Cammer, Michael <[hidden email]> wrote:
>>
>> I have been having problems with B&C for some time and would appreciate help.
>>
>>
>> When I adjust the contrast and hit apply, usually the contrast is not applied.
>
> I am not able to reproduce this problem using ImageJ 1.53g and Java 1.8.0_172 on MacOS and Windows.
>
> -wayne
>
>
>> However, if I adjust the contrast and then duplicate the image, the resulting image does have the contrast applied.
>>
>>
>> I have posted examples.
>>
>> Illustration of problem:
>> http://microscopynotes.com/temp/00_bandc_notapplied.png
>>
>>
>> Example image that does not work:
>> http://microscopynotes.com/temp/00_bandc_data.jpg
>>
>> This has been a problem for at least two months and I checked it tonight with ImageJ 1.53g56 Java 1.8.0_172 Windows 10.
>>
>> Any help appreciated.
>>
>> Best regards-
>>
>>
>>
>> Michael Cammer, Sr Research Scientist, DART Microscopy Laboratory
>>
>> NYU Langone Health, 540 First Avenue, SK2 Microscopy Suite, New York, NY 10016
>>

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Gabriel Landini

Re: bug with Brightness & Contrast?

In reply to this post by Wayne Rasband-2

On Monday, 30 November 2020 18:27:54 GMT you wrote:

> > On Nov 29, 2020, at 11:29 PM, Cammer, Michael
> > <[hidden email]> wrote:
> >
> > I have been having problems with B&C for some time and would appreciate
> > help.
> >
> >
> > When I adjust the contrast and hit apply, usually the contrast is not
> > applied.
> I am not able to reproduce this problem using ImageJ 1.53g and Java
> 1.8.0_172 on MacOS and Windows.

Cammer, Michael-3

Re: bug with Brightness & Contrast?

I am surprised that you cannot reproduce the problem. The histogram does not change and the image is not updated. It occurs with the clown image but not when I make a new 8 or 16 bit ramp image. "Apply" means specifically that the values should be changed, and this is what happens with a 8 or 16 bit image.

The new window that pops up with a warning that the values will be changed also slows things down. Could an option be added please that eliminates this pop up?

Cheers-

Michael Cammer, Sr Research Scientist, DART Microscopy Laboratory

NYU Langone Health, 540 First Avenue, SK2 Microscopy Suite, New York, NY 10016

[hidden email]<mailto:[hidden email]> http://nyulmc.org/micros http://microscopynotes.com/

Voice direct only, no text or messages: 1-914-309-3270 and 1-646-501-0567

________________________________
<[hidden email]>
Sent: Monday, November 30, 2020 2:07 PM

Subject: Re: bug with Brightness & Contrast?

[EXTERNAL]

On Monday, 30 November 2020 18:27:54 GMT you wrote:

I can reproduce it, sometimes, with the image provided (IJ 1.53g57, Java
14.0.2, linux).

I think there is an issue with and that can be seen in the tiny histogram
shown in the B/C applet which does not seems to update after hitting "Apply".
However a new Analyze>Histogram shows that the brightness conversion has been
applied. It is not reproducible 100% of the time.

Another instance where it seems to "not work" is this:
Click Auto,
Click Apply and press OK in the dialog.
The tiny histogram does not update.
Click Reset and the image goes back to the original.
I would have expected that if the auto-contrast has been "applied" then the
reset button would not do anything.

Cheers

Gabriel

--
ImageJ mailing list: https://urldefense.proofpoint.com/v2/url?u=http-3A__imagej.nih.gov_ij_list.html&d=DwICAg&c=j5oPpO0eBH1iio48DtsedeElZfc04rx3ExJHeIIZuCs&r=E0xNnPAQpUbDiPlC50tp7rW2nBkvV7fujQf0RknE5bU&m=_cXJvyW_3_Swur7kD4xPlJUtTRXDgqft5sRNiGIzvnI&s=MZ-KFkx9I0-QTS3JN4VX0n6oCuqXPMO-tdubnU44bc4&e=

------------------------------------------------------------
This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain information that is proprietary, confidential, and exempt from disclosure under applicable law. Any unauthorized review, use, disclosure, or distribution is prohibited. If you have received this email in error please notify the sender by return email and delete the original message. Please note, the recipient should check this email and any attachments for the presence of viruses. The organization accepts no liability for any damage caused by any virus transmitted by this email.
=================================

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Wayne Rasband-2

Re: bug with Brightness & Contrast?

> On Nov 30, 2020, at 2:50 PM, Cammer, Michael <[hidden email]> wrote:
>
> I am surprised that you cannot reproduce the problem. The histogram does not change and the image is not updated. It occurs with the clown image but not when I make a new 8 or 16 bit ramp image. "Apply" means specifically that the values should be changed, and this is what happens with a 8 or 16 bit image.

With the latest daily build (1.53g58), the histogram of single RGB images is updated as you change the brightness and contrast and the “Apply” button does nothing. The daily build also fixes the Image>Adjust>Color Balance problem that Michael Schmid reported.

> The new window that pops up with a warning that the values will be changed also slows things down. Could an option be added please that eliminates this pop up?

The “WARNING: the pixel values will change if you click ‘OK’” should not have been used with RGB images since all brightness and contrast adjustments change the pixel values.

-wayne

> ________________________________
> <[hidden email]>
> Sent: Monday, November 30, 2020 2:07 PM
>
> Subject: Re: bug with Brightness & Contrast?
>
> [EXTERNAL]
>
> On Monday, 30 November 2020 18:27:54 GMT you wrote:
>>> On Nov 29, 2020, at 11:29 PM, Cammer, Michael
>>> <[hidden email]> wrote:
>>>
>>> I have been having problems with B&C for some time and would appreciate
>>> help.
>>>
>>>
>>> When I adjust the contrast and hit apply, usually the contrast is not
>>> applied.
>> I am not able to reproduce this problem using ImageJ 1.53g and Java
>> 1.8.0_172 on MacOS and Windows.
>
>
> I can reproduce it, sometimes, with the image provided (IJ 1.53g57, Java
> 14.0.2, linux).
>
> I think there is an issue with and that can be seen in the tiny histogram
> shown in the B/C applet which does not seems to update after hitting "Apply".
> However a new Analyze>Histogram shows that the brightness conversion has been
> applied. It is not reproducible 100% of the time.
>
> Another instance where it seems to "not work" is this:
> Click Auto,
> Click Apply and press OK in the dialog.
> The tiny histogram does not update.
> Click Reset and the image goes back to the original.
> I would have expected that if the auto-contrast has been "applied" then the
> reset button would not do anything.
>
> Cheers
>
> Gabriel

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Cammer, Michael-3

Re: bug with Brightness & Contrast?

Thank you for the update with the nifty moving histogram and the warning window eliminated.

However, the Apply button in the B&C window does not appear to do anything. Clicking it makes no change to the image.

In a macro there are a few possible strategies for a work around and working live the best ones I've found instead of the Apply button are select-all followed by crop or duplicating the image.

Cheers-

Michael Cammer, Sr Research Scientist, DART Microscopy Laboratory

NYU Langone Health, 540 First Avenue, SK2 Microscopy Suite, New York, NY 10016

[hidden email]<mailto:[hidden email]> http://nyulmc.org/micros http://microscopynotes.com/

Voice direct only, no text or messages: 1-914-309-3270 and 1-646-501-0567

________________________________
From: Wayne Rasband <[hidden email]>
Sent: Monday, November 30, 2020 7:56 PM
Subject: Re: bug with Brightness & Contrast?

[EXTERNAL]

> On Nov 30, 2020, at 2:50 PM, Cammer, Michael <[hidden email]> wrote:
>
> I am surprised that you cannot reproduce the problem. The histogram does not change and the image is not updated. It occurs with the clown image but not when I make a new 8 or 16 bit ramp image. "Apply" means specifically that the values should be changed, and this is what happens with a 8 or 16 bit image.

With the latest daily build (1.53g58), the histogram of single RGB images is updated as you change the brightness and contrast and the “Apply” button does nothing. The daily build also fixes the Image>Adjust>Color Balance problem that Michael Schmid reported.

> The new window that pops up with a warning that the values will be changed also slows things down. Could an option be added please that eliminates this pop up?

The “WARNING: the pixel values will change if you click ‘OK’” should not have been used with RGB images since all brightness and contrast adjustments change the pixel values.

-wayne

--
ImageJ mailing list: https://urldefense.proofpoint.com/v2/url?u=http-3A__imagej.nih.gov_ij_list.html&d=DwIFaQ&c=j5oPpO0eBH1iio48DtsedeElZfc04rx3ExJHeIIZuCs&r=hUBj2D5n6oKThx2L01qn8IORZb5f-ruLVXPmQ1zQNnM&m=Dm3LoO_g0e3HAUhTLhyYVk3v5RSVckXAXRNi8GbXiIo&s=E4ityXZrAv1OGz2BIkno0C4Zt5TJiHRa_7Gk9PaYVhk&e=

------------------------------------------------------------
This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain information that is proprietary, confidential, and exempt from disclosure under applicable law. Any unauthorized review, use, disclosure, or distribution is prohibited. If you have received this email in error please notify the sender by return email and delete the original message. Please note, the recipient should check this email and any attachments for the presence of viruses. The organization accepts no liability for any damage caused by any virus transmitted by this email.
=================================

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

Gabriel Landini

Re: bug with Brightness & Contrast?

On Tuesday, 1 December 2020 02:12:54 GMT Cammer, Michael wrote:
> However, the Apply button in the B&C window does not appear to do anything.
> Clicking it makes no change to the image.

I think that might be because the image is already changed. I get that
impression from Wayne's comment on the "OK dialog" that it was unnecessary
because RGB images brightness and contrast adjustments change the pixel values
directly.

The Apply button, however, does something: it redraws the transfer function
and the range values of the small histogram in the B/C applet.

Cheers

Gabriel

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html